* Bugs 15748/51/52/55 fixed: min & max hardly worked with sparses 99/20499/10
authorSamuel GOUGEON <sgougeon@free.fr>
Sun, 16 Sep 2018 18:22:23 +0000 (20:22 +0200)
committerCedric Delamarre <cdl@esi-group.com>
Fri, 18 Jan 2019 15:56:03 +0000 (16:56 +0100)
commit7674361914367eef2bc03163478e83061b926ddd
treeb112a39be0ab071440b732f10d212bde772f7dfe
parentf9226a203d609a513f9bac289b5a246283dd70e2
* Bugs 15748/51/52/55 fixed: min & max hardly worked with sparses

  - http://bugzilla.scilab.org/15748 :
     min(Sparse,"c"|"r") and max(Sparse,"c"|"r") returned vectors of zeros.
  - http://bugzilla.scilab.org/15751 :
     min(sparse([],[])) returns 0 instead of []. Same issue with max()
  - http://bugzilla.scilab.org/15752 :
     min() and max() did not ignore %nan in sparses
  - http://bugzilla.scilab.org/15755 :
     min() and max() did not allow mixing sparse inputs with scalars
  - The second output k was not implemented for sparses.

  Code enabled and simplified a lot:
    * min(A): the code was very complicated
    * min(A,"c") duplicated the code for min(A,"r"), while both cases
      just differ by a transposition.
    * With the new simple and fast implementation, min(row,"r"|"c") and
      min(col,"r"|"c") no longer uses a special processing
    * Processing min(A,B) duplicated the code for min(A,B,C,..)
  Other code improvement:
    * Inputs are now tested to be real.
  Help pages:
    * Syntaxes unfolded
    * Arguments were hardly documented.
    * Examples: There were no example for "c"|"r", nor with sparses
      Examples were not illustrated.
    * See also: strange was missing
    Too many changes => to be retranslated from en_US.

Change-Id: I5e322dc34b0c33067a435029065895c654f57fc8
15 files changed:
scilab/CHANGES.md
scilab/modules/elementary_functions/help/en_US/matrixoperations/max.xml
scilab/modules/elementary_functions/help/en_US/matrixoperations/min.xml
scilab/modules/elementary_functions/help/fr_FR/matrixoperations/max.xml [deleted file]
scilab/modules/elementary_functions/help/fr_FR/matrixoperations/min.xml [deleted file]
scilab/modules/elementary_functions/help/ja_JP/matrixoperations/max.xml [deleted file]
scilab/modules/elementary_functions/help/ja_JP/matrixoperations/min.xml [deleted file]
scilab/modules/elementary_functions/help/pt_BR/matrixoperations/max.xml [deleted file]
scilab/modules/elementary_functions/help/pt_BR/matrixoperations/min.xml [deleted file]
scilab/modules/elementary_functions/help/ru_RU/matrixoperations/max.xml
scilab/modules/elementary_functions/help/ru_RU/matrixoperations/min.xml
scilab/modules/elementary_functions/macros/%sp_max.sci
scilab/modules/elementary_functions/macros/%sp_min.sci
scilab/modules/elementary_functions/tests/unit_tests/max.dia.ref [deleted file]
scilab/modules/elementary_functions/tests/unit_tests/max.tst