Xcos: remove the checked FIXME on the code

Change-Id: Ie1760be2012cdfeaba57508883e6f73c8cd79fdb

diff --git a/scilab/modules/xcos/src/java/org/scilab/modules/xcos/graph/model/XcosCell.java b/scilab/modules/xcos/src/java/org/scilab/modules/xcos/graph/model/XcosCell.java
index c2a52e7..1f5feda 100644 (file)
--- a/scilab/modules/xcos/src/java/org/scilab/modules/xcos/graph/model/XcosCell.java
+++ b/scilab/modules/xcos/src/java/org/scilab/modules/xcos/graph/model/XcosCell.java
@@ -445,10 +445,9 @@ public class XcosCell extends ScilabGraphUniqueObject {
         VectorOfScicosID children = new VectorOfScicosID();
         final ObjectProperties property = relatedPortKindProperty(v[0]);
 
-
-        // FIXME manage the index argument, possibly by counting the JGraphX children by kind
         if (property != null) {
             controller.getObjectProperty(getUID(), getKind(), property, children);
+            // do no use the index argument as it is not possible to insert out of order on the MVC (as we have kind of port)
             children.add(c.getUID());
             controller.setObjectProperty(getUID(), getKind(), property, children);
         }

diff --git a/scilab/modules/xcos/src/java/org/scilab/modules/xcos/io/codec/BasicBlockCodec.java b/scilab/modules/xcos/src/java/org/scilab/modules/xcos/io/codec/BasicBlockCodec.java
index d2ee463..a9c9ede 100644 (file)
--- a/scilab/modules/xcos/src/java/org/scilab/modules/xcos/io/codec/BasicBlockCodec.java
+++ b/scilab/modules/xcos/src/java/org/scilab/modules/xcos/io/codec/BasicBlockCodec.java
@@ -124,9 +124,6 @@ public class BasicBlockCodec extends XcosObjectCodec {
      */
     @Override
     public Object beforeEncode(mxCodec enc, Object obj, Node node) {
-        // FIXME is it needed ?
-        //        ((Element) node).setAttribute(SIMULATION_FUNCTION_TYPE, String.valueOf(((BasicBlock) obj).getSimulationFunctionType()));
-
         /*
          * Log some information
          */

diff --git a/scilab/modules/xcos/src/java/org/scilab/modules/xcos/io/codec/BasicPortCodec.java b/scilab/modules/xcos/src/java/org/scilab/modules/xcos/io/codec/BasicPortCodec.java
index 5101441..65996f4 100644 (file)
--- a/scilab/modules/xcos/src/java/org/scilab/modules/xcos/io/codec/BasicPortCodec.java
+++ b/scilab/modules/xcos/src/java/org/scilab/modules/xcos/io/codec/BasicPortCodec.java
@@ -105,9 +105,6 @@ public class BasicPortCodec extends XcosObjectCodec {
      */
     @Override
     public Object beforeEncode(mxCodec enc, Object obj, Node node) {
-        // FIXME find a valid usage of this
-        //        ((Element) node).setAttribute(DATA_TYPE, String.valueOf(((BasicPort) obj).getDataType()));
-
         /*
          * Log some information
          */
@@ -168,15 +165,6 @@ public class BasicPortCodec extends XcosObjectCodec {
         final BasicPort port = (BasicPort) obj;
         final String attr = ((Element) node).getAttribute(DATA_TYPE);
 
-        // FIXME find a valid usage of that
-        //        // set default data type
-        //        if (attr == null || attr.equals("")) {
-        //            port.setDataType(BasicPort.DataType.REAL_MATRIX);
-        //
-        //        } else {
-        //            port.setDataType(BasicPort.DataType.valueOf(attr));
-        //        }
-
         // update connectable flag
         port.setConnectable(true);
 
@@ -244,13 +232,6 @@ public class BasicPortCodec extends XcosObjectCodec {
         flipped = Boolean.parseBoolean(parentBlockMap.get(ScilabGraphConstants.STYLE_FLIP));
         mirrored = Boolean.parseBoolean(parentBlockMap.get(ScilabGraphConstants.STYLE_MIRROR));
 
-        // FIXME handle that compatibility
-        //        final int baseAngle = orientation.getRelativeAngle(((BasicBlock) obj.getParent()).getAngle(), obj.getClass(), flipped, mirrored);
-        //
-        //        if (rotation == baseAngle) {
-        //            return;
-        //        }
-
         // Calculate the rotation for this kind of port.
         rotation = orientation.getAbsoluteAngle(obj.getClass(), flipped, mirrored);
 

diff --git a/scilab/modules/xcos/src/java/org/scilab/modules/xcos/io/writer/CustomWriter.java b/scilab/modules/xcos/src/java/org/scilab/modules/xcos/io/writer/CustomWriter.java
index e8d430a..9946601 100644 (file)
--- a/scilab/modules/xcos/src/java/org/scilab/modules/xcos/io/writer/CustomWriter.java
+++ b/scilab/modules/xcos/src/java/org/scilab/modules/xcos/io/writer/CustomWriter.java
@@ -103,7 +103,7 @@ public class CustomWriter extends ScilabWriter {
                 }
                 break;
             case PORT:
-                // FIXME encode orientation from the model or not?
+                // the orientation is not encoded on the model but propagated inside the style
                 break;
             default:
                 break;